Attention is currently required from: laforge, fixeria, dexter.

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32995 )

Change subject: RLCMAC_CSN1_Types: Add release 6 additions to PacketCellChangeNotification ......................................................................

Patch Set 1:

(3 comments)

File library/RLCMAC_CSN1_Templates.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32995/comment/330ac55e_0e709... PS1, Line 166: utran_target_cell_presence := omit,

I am bit surprised that non present optional fields must not be unbound. […]

the PRESENCE is used during decoding, not during encoding afaik. I guess this allows generating incorrect messages on purpose for testing purposes?

File library/RLCMAC_CSN1_Types.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32995/comment/616d850c_9d2d6... PS1, Line 1016: BIT1 ba_psi3_presence, Add a /* TODO: Rel-8 addition */ here

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32995/comment/5d537756_897ea... PS1, Line 1030: variant (utran_target_cell) "PRESENCE(arfcn_bsic_presence = '1'B, utran_target_cell_presence = '0'B)"

This describes the escape bit mechanism: […]

I think it may make sense to have the ARFCN+BSIC CSN.1 struct as a record here, it would simplify a bit this imho.

Also, you may want to have a look at TAG, it may be clearer here, since in here it's not really about optional fields, but about taking one or another substruct.