Attention is currently required from: Hoernchen, laforge. Hello Jenkins Builder, laforge, lynxis lazus, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/simtrace2/+/43128?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: firmware: card_emu: fix 7816-3 10.3.2 0=256 case ...................................................................... firmware: card_emu: fix 7816-3 10.3.2 0=256 case add_tpdu_byte() accumulates bytes received from the reader, but passes reader_to_card = 0, but ISO 7816-3 10.3.2 says P3 == 0 means 256 not 0 Only reachable with P3 == 0 in a receive data phase, but simtrace2-cardem-pcsc only requests PB_AND_RX when there is command data. Fix this anyway. Change-Id: I0fa4741bc1293549816595e6b4e8af9e22bcfbc1 --- M firmware/libcommon/source/card_emu.c 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/28/43128/2 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/43128?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I0fa4741bc1293549816595e6b4e8af9e22bcfbc1 Gerrit-Change-Number: 43128 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu> Gerrit-Attention: Hoernchen <ewild@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org>