Attention is currently required from: laforge. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/39198?usp=email ) Change subject: javacard: add parser for JAVA-card CAP file format ...................................................................... Patch Set 3: (4 comments) File pySim/javacard.py: https://gerrit.osmocom.org/c/pysim/+/39198/comment/fa80b4d3_e333a8c8?usp=ema... : PS2, Line 47: __component

AFAICT, you are basically declaring a _class_ variable here. […] I have now looked it up. Python seems to have a very wired understanding of those class variables. As far as I understand now, a class variable in python is indeed shared over all instances, but when I change it, it become shadowed by an instance variable. Maybe class variables as python understands them are intended to be used for constants or parameters with default values that are rarely changed?

https://gerrit.osmocom.org/c/pysim/+/39198/comment/3df51909_b33604ce?usp=ema... : PS2, Line 99:

I think a generic implementation of a CAP file support shouldn't return the loadfile as hex-string b […] Done

https://gerrit.osmocom.org/c/pysim/+/39198/comment/897c1830_1cdb64c7?usp=ema... : PS2, Line 118: def get_loadfile_aid(self):

missing declaration of return type (-> Hexstr) Done

https://gerrit.osmocom.org/c/pysim/+/39198/comment/0c43e2f7_79b893d1?usp=ema... : PS2, Line 127: def get_applet_aid(self, index:int = 0):

missing declaration of return type (-> Hexstr) Done

-- To view, visit https://gerrit.osmocom.org/c/pysim/+/39198?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I581483ccb9d8a254fcecc995fec3c811c5cf38eb Gerrit-Change-Number: 39198 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge@osmocom.org> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Comment-Date: Mon, 06 Jan 2025 15:58:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge@osmocom.org>