Attention is currently required from: laforge.

4 comments:

File pySim/javacard.py:
- Patch Set #2, Line 47: __component
  AFAICT, you are basically declaring a _class_ variable here. […]
  I have now looked it up. Python seems to have a very wired understanding of those class variables. As far as I understand now, a class variable in python is indeed shared over all instances, but when I change it, it become shadowed by an instance variable. Maybe class variables as python understands them are intended to be used for constants or parameters with default values that are rarely changed?
- Patch Set #2, Line 99:
  I think a generic implementation of a CAP file support shouldn't return the loadfile as hex-string b […]
  Done
- Patch Set #2, Line 118: def get_loadfile_aid(self):
  missing declaration of return type (-> Hexstr)
  Done
- Patch Set #2, Line 127: def get_applet_aid(self, index:int = 0):
  missing declaration of return type (-> Hexstr)
  Done

To view, visit change 39198. To unsubscribe, or for help writing mail filters, visit settings.