Attention is currently required from: dexter, fixeria.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-pcu/+/35151?usp=email )
Change subject: gprs_rlcmac_sched: rewrite logic around idle block skip
......................................................................
Patch Set 2: -Code-Review
(1 comment)
File src/gprs_rlcmac_sched.cpp:
https://gerrit.osmocom.org/c/osmo-pcu/+/35151/comment/37d05e16_c8ed98a1
PS1, Line 486: * way we help BTS energy saving (on TRX!=C0) by sending nothing
Oh, I overlooked the `skip_idle && trx != 0`
part in the old code (left side). […]
@vyanitskiy@sysmocom.de bear in mind the
"skip_idle && trx != 0" was only applied inside the #ifdef DIRECT_PHY,
so it was only really applied for sysmobts,lc15,oc2g. And that was done in order to make
it send stuff on C0 because those osmo-bts lowerlayers are not filling the block
otherwise. For trx!=0 it's fine sending empty block to those osmo-bts flavours,
because it's fine if they end up transmitting nothing on those TRX.
I realize now though, that when proposing the cleanup in this patch, I assumed those were
1 TRX only, but lc15 has several of them right?
With the current version of the patch, it will still transmit dummy blocks on trx!=0, and
that's not what we want. We want to transmit nothing on trx!=0.
So the could should be left as it was and this patch dropped? Maybe we can reuse this
patch to rename bts->gen_idle_blocks to be "gen_idle_block_C0".
--
To view, visit
https://gerrit.osmocom.org/c/osmo-pcu/+/35151?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Iadb62748b18605bf158169b317f880352bc0a5a6
Gerrit-Change-Number: 35151
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 29 Nov 2023 12:32:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: comment