Attention is currently required from: dexter, fixeria.

Patch set 2:-Code-Review

View Change

1 comment:

• File src/gprs_rlcmac_sched.cpp:

  • Patch Set #1, Line 486: * way we help BTS energy saving (on TRX!=C0) by sending nothing

    Oh, I overlooked the `skip_idle && trx != 0` part in the old code (left side). […]

    @vyanitskiy@sysmocom.de bear in mind the "skip_idle && trx != 0" was only applied inside the #ifdef DIRECT_PHY, so it was only really applied for sysmobts,lc15,oc2g. And that was done in order to make it send stuff on C0 because those osmo-bts lowerlayers are not filling the block otherwise. For trx!=0 it's fine sending empty block to those osmo-bts flavours, because it's fine if they end up transmitting nothing on those TRX.

    I realize now though, that when proposing the cleanup in this patch, I assumed those were 1 TRX only, but lc15 has several of them right?
    With the current version of the patch, it will still transmit dummy blocks on trx!=0, and that's not what we want. We want to transmit nothing on trx!=0.

    So the could should be left as it was and this patch dropped? Maybe we can reuse this patch to rename bts->gen_idle_blocks to be "gen_idle_block_C0".

To view, visit change 35151. To unsubscribe, or for help writing mail filters, visit settings.