Attention is currently required from: fixeria.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-hnbgw/+/28837 )
Change subject: tests/ranap_rab_ass: fix NULL pointer dereference
......................................................................
Patch Set 1:
(1 comment)
File tests/ranap_rab_ass/ranap_rab_ass_test.c:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/28837/comment/e8084232_882b8db9
PS1, Line 67: if (encoded != NULL) {
I'm a bit lost here. Is this really returning encoded=NULL at all? the commit message
seems to be indicating so, but I doubt it.
If at all, it should be "Fix potential null pointer dereference".
In any case, I think adding an OSMO_ASSERT(encoded) would be preferable here.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-hnbgw/+/28837
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: I16fea7b2a8cb1d693e01c91d7633550e2e599ceb
Gerrit-Change-Number: 28837
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 29 Jul 2022 12:28:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment