Attention is currently required from: osmith, fixeria.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-gprs/+/31098 )
Change subject: rlcmac: Enqueue LLC PDUs based on RadioPriority and SAPI
......................................................................
Patch Set 3:
(2 comments)
File src/rlcmac/gre.c:
https://gerrit.osmocom.org/c/libosmo-gprs/+/31098/comment/a0cf1290_1a001789
PS3, Line 72: /* TODO: here a new UL TBF will be created if not available yet */
I guess you kept this on purpose?
Yes, I'm
adding code modules in a step-by-step way, so that it's not a final code bomb with 30
files and 50k lines which will be impossible to review.
File src/rlcmac/llc_queue.c:
https://gerrit.osmocom.org/c/libosmo-gprs/+/31098/comment/30042095_1b7a4e2a
PS3, Line 196: /* rate_ctr_inc(CTR_LLC_FRAME_DROPPED); */
commented out code. […]
I left it there on
purpose so that a potential counter can be identified quickly and added there in the
future.
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-gprs/+/31098
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-gprs
Gerrit-Branch: master
Gerrit-Change-Id: Icdaa046fb6a71367f10beee16dcf9a5b7b61022e
Gerrit-Change-Number: 31098
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 30 Jan 2023 12:06:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: comment