Attention is currently required from: osmith, fixeria.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-gprs/+/31098 )
Change subject: rlcmac: Enqueue LLC PDUs based on RadioPriority and SAPI
......................................................................
Patch Set 3:
(1 comment)
File src/rlcmac/llc_queue.c:
https://gerrit.osmocom.org/c/libosmo-gprs/+/31098/comment/f9fb0069_1f341ace
PS3, Line 155: break;
does this intentionally only break the inner loop?
Good catch, this is wrong :) that's because I added an extra axis of priorities
and updated the code but didn't see what you mention. I'll fix it.
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-gprs/+/31098
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-gprs
Gerrit-Branch: master
Gerrit-Change-Id: Icdaa046fb6a71367f10beee16dcf9a5b7b61022e
Gerrit-Change-Number: 31098
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 30 Jan 2023 12:08:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: comment