Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/31623 ) Change subject: Introduce debian-bullseye-titan-master ...................................................................... Patch Set 1: (6 comments) File debian-bullseye-titan-master/Dockerfile: https://gerrit.osmocom.org/c/docker-playground/+/31623/comment/4183f031_8021... PS1, Line 32: Install titan.core dependencies

How about using `apt-get build-dep` for that? This way we [hopefully] always install all dependencie […] Because there's no debian/control in upstream, like in open5gs, so that makes no sense since we'd still need to maintain debian/control files ourselves.

https://gerrit.osmocom.org/c/docker-playground/+/31623/comment/bc4cd868_b1fd... PS1, Line 74: j8

`$nproc`? Ack

https://gerrit.osmocom.org/c/docker-playground/+/31623/comment/a4eedbdd_a975... PS1, Line 94: wget

Why not using Docker's `ADD` here to fetch a file? The benefit of using it is that the cache will be […] I simply copied this from the other docker. Changing this is a different topic. If someone wants to change this he can do so in both dockerfiles.

File debian-bullseye-titan-master/Makefile: https://gerrit.osmocom.org/c/docker-playground/+/31623/comment/710beec2_cddf... PS1, Line 1: ../debian-bullseye-titan/Makefile

"No newline at end of right file. […] This is a symlink, I'm not modifying any content ;)

File debian-bullseye-titan-master/ttcn3-docker-prepare.sh: https://gerrit.osmocom.org/c/docker-playground/+/31623/comment/30aea349_a093... PS1, Line 1: #!/bin/sh -e

Might be a good idea to move this file to `common/` and `ADD` it from there, to avoid code duplicati […] Ack

File debian-bullseye-titan-master/ttcn3-docker-run.sh: https://gerrit.osmocom.org/c/docker-playground/+/31623/comment/584fa4a6_5678... PS1, Line 1: #!/bin/bash

Same here, move this file to `common/`. Ack

-- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/31623 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I19ee98a319ccad167d06c4f183fe80ecac909483 Gerrit-Change-Number: 31623 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Comment-Date: Thu, 02 Mar 2023 10:33:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de> Gerrit-MessageType: comment