Attention is currently required from: fixeria.

View Change

6 comments:

• File debian-bullseye-titan-master/Dockerfile:

  • Patch Set #1, Line 32: Install titan.core dependencies

    How about using `apt-get build-dep` for that? This way we [hopefully] always install all dependencie […]

    Because there's no debian/control in upstream, like in open5gs, so that makes no sense since we'd still need to maintain debian/control files ourselves.

  • Patch Set #1, Line 74: j8

    `$nproc`?

    Ack

  • Patch Set #1, Line 94: wget

    Why not using Docker's `ADD` here to fetch a file? The benefit of using it is that the cache will be […]

    I simply copied this from the other docker. Changing this is a different topic. If someone wants to change this he can do so in both dockerfiles.

• File debian-bullseye-titan-master/Makefile:

  • Patch Set #1, Line 1: ../debian-bullseye-titan/Makefile

    "No newline at end of right file. […]

    This is a symlink, I'm not modifying any content ;)

• File debian-bullseye-titan-master/ttcn3-docker-prepare.sh:

  • Patch Set #1, Line 1: #!/bin/sh -e

    Might be a good idea to move this file to `common/` and `ADD` it from there, to avoid code duplicati […]

    Ack

• File debian-bullseye-titan-master/ttcn3-docker-run.sh:

  • Patch Set #1, Line 1: #!/bin/bash

    Same here, move this file to `common/`.

    Ack

To view, visit change 31623. To unsubscribe, or for help writing mail filters, visit settings.