Attention is currently required from: arehbein, laforge, daniel.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-netif/+/33201 )
Change subject: stream: Add and use IPA send function
......................................................................
Patch Set 14:
(4 comments)
File tests/stream/stream_test.c:
https://gerrit.osmocom.org/c/libosmo-netif/+/33201/comment/414107df_7aa2db2f
PS14, Line 387: #define IPAC_MSG_IDREQ_PAYLOAD_INITIALIZER\
missing space before \
https://gerrit.osmocom.org/c/libosmo-netif/+/33201/comment/a8607de9_bdcca102
PS14, Line 388: IPAC_MSGT_ID_GET,\
same
https://gerrit.osmocom.org/c/libosmo-netif/+/33201/comment/2316bf99_62c7c085
PS14, Line 397: IPAC_MSG_IDREQ_PAYLOAD_INITIALIZER
why did this change here? unrelated?
https://gerrit.osmocom.org/c/libosmo-netif/+/33201/comment/c1a202f9_5ccd4db6
PS14, Line 582: osmo_ipa_stream_srv_send(conn, IPAC_PROTO_IPACCESS, -1, m);
I still think mixing filling the msgb (just 1-2 API calls) + sending is a bad idea, but
since others seem to prefer this way then so be it.
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-netif/+/33201
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I61e1fe59166c46595efe8c1f32b8f2607cb6c529
Gerrit-Change-Number: 33201
Gerrit-PatchSet: 14
Gerrit-Owner: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: daniel <dwillmann(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: arehbein <arehbein(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 31 Jul 2023 09:06:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment