Attention is currently required from: arehbein.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-netif/+/33198 )
Change subject: stream: Add client-side (segmentation) support for IPA
......................................................................
Patch Set 16:
(2 comments)
File tests/stream/stream_test.c:
https://gerrit.osmocom.org/c/libosmo-netif/+/33198/comment/053cb1f6_4b0b2f69
PS13, Line 829: rc = clock_gettime(CLOCK_MONOTONIC, &start);
See answer to the same comment on change 33197 […]
I think I already answered in there that the easiest/best way to timeout the test is
to use the alarm() call, to avoid making the test even more complex with mixed calls to
clock_gettime and osmo_clock_gettime. Not critical though.
File tests/stream/stream_test.c:
https://gerrit.osmocom.org/c/libosmo-netif/+/33198/comment/9b81ebfc_d4289221
PS16, Line 518: osmo_timer_schedule(&fragmented_send_tl_cli, 0, 125000);
why this change in time? seems unrelated?
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-netif/+/33198
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I822abf52c6ae396c90b5c50228a0a39c848d3de6
Gerrit-Change-Number: 33198
Gerrit-PatchSet: 16
Gerrit-Owner: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: arehbein <arehbein(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 31 Jul 2023 09:01:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: arehbein <arehbein(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment