Attention is currently required from: pespin, msuraev.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/30301 )
Change subject: osmo-ns-dummy: add rate counters
......................................................................
Patch Set 4: Code-Review-1
(1 comment)
File utils/osmo-ns-dummy.c:
https://gerrit.osmocom.org/c/libosmocore/+/30301/comment/36f3e2b8_20f9bc31
PS3, Line 56: static const struct rate_ctr_desc dummy_ctr_desc[] = {
That program isn't used to test vty interface
either yet it contains one. […]
I think the vty interface is used to configure the
NS test, so it doesn't have a VTY interface to test VTY, as you suggested. I am more
leaning towards pespin's criticism. those dummy counters have nothing to do with NS
testing.
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/30301
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ibd8b17aa3ba9ceb527c6231310f01d736fb542a7
Gerrit-Change-Number: 30301
Gerrit-PatchSet: 4
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: msuraev <msuraev(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 30 Nov 2022 12:49:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de>
Gerrit-MessageType: comment