Attention is currently required from: pespin, msuraev.

Patch set 4:Code-Review -1

View Change

1 comment:

• File utils/osmo-ns-dummy.c:

  • Patch Set #3, Line 56: static const struct rate_ctr_desc dummy_ctr_desc[] = {

    That program isn't used to test vty interface either yet it contains one. […]

    I think the vty interface is used to configure the NS test, so it doesn't have a VTY interface to test VTY, as you suggested. I am more leaning towards pespin's criticism. those dummy counters have nothing to do with NS testing.

To view, visit change 30301. To unsubscribe, or for help writing mail filters, visit settings.