Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/33123 ) Change subject: encoding: only RFN needed in write_immediate_assignment(_reject)() ...................................................................... Patch Set 1: (3 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-pcu/+/33123/comment/8f51b9b1_eb286d67 PS1, Line 7: RFN needed in write_immediate_assignment(_reject)()

I don't understand you here. […] It doesn't matter, so I prefer passing the more restricted RFN in order to avoid depending on RFN->FN conversion in more places. This makes the implementation more dependent here on how/if we are able to calculate full FNs based on RFN. We get an RFN, and we have to encode so that the RFN can be derived again, so feels less cumbersome having to go through RFN->FN->RFN which may only cause possible issues if there's some FN timing bug.

https://gerrit.osmocom.org/c/osmo-pcu/+/33123/comment/ffc7eaac_14b6fc99 PS1, Line 12: 10.5.2.30

3GPP TS 44. […] Ack

File src/bts.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/33123/comment/d2bc64ee_3b996715 PS1, Line 1121: GSM_TDMA_FN_SUM

I think you can remove the `GSM_TDMA_FN_SUM` now and simply do: […] We can have a look at doing this in follow up patches. 21216 being "RFN_MODULUS / 2" is another example on how we are actually dealing with RFNs here instead of requiring full FNs.

-- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/33123 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: If9b758434c00f2a3868534d5be84946809c989a9 Gerrit-Change-Number: 33123 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-CC: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Comment-Date: Thu, 01 Jun 2023 08:21:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de> Gerrit-MessageType: comment