Attention is currently required from: fixeria.

View Change

3 comments:

• Commit Message:

  • Patch Set #1, Line 7: RFN needed in write_immediate_assignment(_reject)()

    I don't understand you here. […]

    It doesn't matter, so I prefer passing the more restricted RFN in order to avoid depending on RFN->FN conversion in more places. This makes the implementation more dependent here on how/if we are able to calculate full FNs based on RFN. We get an RFN, and we have to encode so that the RFN can be derived again, so feels less cumbersome having to go through RFN->FN->RFN which may only cause possible issues if there's some FN timing bug.

  • Patch Set #1, Line 12: 10.5.2.30

    3GPP TS 44. […]

    Ack

• File src/bts.cpp:

  • Patch Set #1, Line 1121: GSM_TDMA_FN_SUM

    I think you can remove the `GSM_TDMA_FN_SUM` now and simply do: […]

    We can have a look at doing this in follow up patches. 21216 being "RFN_MODULUS / 2" is another example on how we are actually dealing with RFNs here instead of requiring full FNs.

To view, visit change 33123. To unsubscribe, or for help writing mail filters, visit settings.