Attention is currently required from: pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31145 ) Change subject: bts: add IMMEDIATE ASSIGNMENT via PCH transmission ...................................................................... Patch Set 4: (4 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-pcu/+/31145/comment/26443a55_33c2ce80 PS3, Line 11: and the BSC also must instruct the BTS to transmit the via PCH instead of

"to transmit the via PCH" transmit the what? Done

https://gerrit.osmocom.org/c/osmo-pcu/+/31145/comment/ec645422_b11305c8 PS3, Line 14:

This commit description seems to be saying that the fact that the DL TBF Imm Ass is sent over PDCH i […] Done

File src/bts.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/31145/comment/90fefc7a_4ff00e21 PS3, Line 1109: pcu_l1if_tx_pch_dt(tbf->tlli(), ms_paging_group(tbf_ms(tbf)), bts, immediate_assignment, plen);

Please don't change the order of params between the 2 similar functions. […] Done

File src/pcu_l1_if.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/31145/comment/c971220c_316412fa PS3, Line 312: uint8_t data[sizeof(tlli) + PAGING_GROUP_LEN + GSM_MACBLOCK_LEN];

const size_t pdu_len = sizeof(tlli) + PAGING_GROUP_LEN + GSM_MACBLOCK_LEN; […] I could also use sizeof(data) but the other functions also seem not to do that.

-- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31145 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I2a78651593323e8b9627c39918d949a33497b70f Gerrit-Change-Number: 31145 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Fri, 03 Feb 2023 13:02:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin@sysmocom.de> Gerrit-MessageType: comment