Attention is currently required from: pespin.

View Change

4 comments:

• Commit Message:

  • Patch Set #3, Line 11: and the BSC also must instruct the BTS to transmit the via PCH instead of

    "to transmit the via PCH" transmit the what?

    Done

  • Patch Set #3, Line 14:

    This commit description seems to be saying that the fact that the DL TBF Imm Ass is sent over PDCH i […]

    Done

• File src/bts.cpp:

  • Patch Set #3, Line 1109: pcu_l1if_tx_pch_dt(tbf->tlli(), ms_paging_group(tbf_ms(tbf)), bts, immediate_assignment, plen);

    Please don't change the order of params between the 2 similar functions. […]

    Done

• File src/pcu_l1_if.cpp:

  • Patch Set #3, Line 312: uint8_t data[sizeof(tlli) + PAGING_GROUP_LEN + GSM_MACBLOCK_LEN];

    const size_t pdu_len = sizeof(tlli) + PAGING_GROUP_LEN + GSM_MACBLOCK_LEN; […]

    I could also use sizeof(data) but the other functions also seem not to do that.

To view, visit change 31145. To unsubscribe, or for help writing mail filters, visit settings.