Attention is currently required from: pespin. matanp has posted comments on this change. ( https://gerrit.osmocom.org/c/gapk/+/32094 ) Change subject: fmt_rtp_amr,fmt_rtp_efr: replace damaged packets with silence ...................................................................... Patch Set 3: (3 comments) File src/fmt_rtp_amr.c: https://gerrit.osmocom.org/c/gapk/+/32094/comment/5e4eeea0_d1879047 PS2, Line 30: static const uint8_t SILENCE[] = {0x80, 0x44, 0x00, 0x00, 0x00, 0x00, 0x00};

can you add a some comment with some spec reference as from where this hexstring comes from? Ack

File src/fmt_rtp_efr.c: https://gerrit.osmocom.org/c/gapk/+/32094/comment/81820468_713af606 PS2, Line 33: static const uint8_t DAMAGED_PACKET[EFR_LEN] = {

Same here. Ack

https://gerrit.osmocom.org/c/gapk/+/32094/comment/2f0f3bfc_a952cfe2 PS2, Line 70: if (!memcmp(DAMAGED_PACKET, src, EFR_LEN))

is EFR_LEN garanteed to be == src_len here? Yes, the if statement in line 65 checks it

-- To view, visit https://gerrit.osmocom.org/c/gapk/+/32094 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: gapk Gerrit-Branch: master Gerrit-Change-Id: I7245aa0bc0955cc8b94d5401a15e694f50498093 Gerrit-Change-Number: 32094 Gerrit-PatchSet: 3 Gerrit-Owner: matanp <matan1008@gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge@osmocom.org> Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Tue, 28 Mar 2023 13:57:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin@sysmocom.de> Gerrit-MessageType: comment