Attention is currently required from: pespin.

View Change

3 comments:

• File src/fmt_rtp_amr.c:

  • Patch Set #2, Line 30: static const uint8_t SILENCE[] = {0x80, 0x44, 0x00, 0x00, 0x00, 0x00, 0x00};

    can you add a some comment with some spec reference as from where this hexstring comes from?

    Ack

• File src/fmt_rtp_efr.c:

  • Patch Set #2, Line 33: static const uint8_t DAMAGED_PACKET[EFR_LEN] = {

    Same here.

    Ack

  • Patch Set #2, Line 70: if (!memcmp(DAMAGED_PACKET, src, EFR_LEN))

    is EFR_LEN garanteed to be == src_len here?

    Yes, the if statement in line 65 checks it

To view, visit change 32094. To unsubscribe, or for help writing mail filters, visit settings.