Attention is currently required from: neels, pespin.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-cbc/+/28822 )
Change subject: sbcap: Request and handle Write Replace Warning Indication
......................................................................
Patch Set 3: Code-Review+1
(2 comments)
File include/osmocom/cbc/smscb_message_fsm.h:
https://gerrit.osmocom.org/c/osmo-cbc/+/28822/comment/266e9610_0b5177de
PS3, Line 35: SMSCB_E_SBCAP_WRITE_IND,
are you sure the name shouldn't reflect more than
"WRITE" if it is called Write Replace Warning?
the difference (at least in
cbsp / sabp) is that WRITE would *not* replace. Not sure how it is in SBcAP...
File src/sbcap_msg.c:
https://gerrit.osmocom.org/c/osmo-cbc/+/28822/comment/1840b15f_aefa3a19
PS3, Line 231: ie = sbcap_alloc_Write_Replace_Warning_Request_IE(24,
SBcAP_Criticality_ignore,
is 24 a magic nr or a placeholder token? […]
the
comment above should make it clear. I'm just wondering why we are not using that
asn_VAL_14_SBcAP_id_Send_Write_Replace_Warning_Indication ?
--
To view, visit
https://gerrit.osmocom.org/c/osmo-cbc/+/28822
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-cbc
Gerrit-Branch: master
Gerrit-Change-Id: I563e7d1c999f14b8197bb41e85b7bcf6262fe2a0
Gerrit-Change-Number: 28822
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 29 Jul 2022 11:14:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Gerrit-MessageType: comment