Attention is currently required from: neels, pespin.

Patch set 3:Code-Review +1

View Change

2 comments:

• File include/osmocom/cbc/smscb_message_fsm.h:

  • Patch Set #3, Line 35: SMSCB_E_SBCAP_WRITE_IND,

    are you sure the name shouldn't reflect more than "WRITE" if it is called Write Replace Warning?

    the difference (at least in cbsp / sabp) is that WRITE would *not* replace. Not sure how it is in SBcAP...

• File src/sbcap_msg.c:

  • Patch Set #3, Line 231: ie = sbcap_alloc_Write_Replace_Warning_Request_IE(24, SBcAP_Criticality_ignore,

    is 24 a magic nr or a placeholder token? […]

    the comment above should make it clear. I'm just wondering why we are not using that asn_VAL_14_SBcAP_id_Send_Write_Replace_Warning_Indication ?

To view, visit change 28822. To unsubscribe, or for help writing mail filters, visit settings.