Attention is currently required from: neels, laforge, fixeria. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31176 ) Change subject: support for Ericsson RBS E1 CCU ...................................................................... Patch Set 27: (5 comments) File configure.ac: https://gerrit.osmocom.org/c/osmo-pcu/+/31176/comment/98b0a6f1_95f3f9d1 PS24, Line 90: PKG_CHECK_MODULES(LIBOSMOABIS, libosmoabis >= 1.4.0)

So the E1 CCU feature is configurable via `--enable-er-e1-ccu` and is disabled by default, but you'r […] Done

File contrib/jenkins.sh: https://gerrit.osmocom.org/c/osmo-pcu/+/31176/comment/c7747258_53464777 PS24, Line 59: PCU_CONFIG="$PCU_CONFIG --enable-werror --enable-sanitize"

You should add `--enable-er-e1-ccu` here, so that the conditional code is also built by Jenkins. The echo above says explicitly "Direct DSP access disabled, sanitizer enabled" are we sure we want to enable --enable-er-e1-ccu in this path?

File contrib/osmo-pcu.spec.in: https://gerrit.osmocom.org/c/osmo-pcu/+/31176/comment/05ce959f_65c48320 PS24, Line 36: 1.3.0

You require 1.4.0 in `configure.ac`, but 1.3. […] Done

File src/ericsson-rbs/er_ccu_descr.h: https://gerrit.osmocom.org/c/osmo-pcu/+/31176/comment/d56d4a04_032f8b31 PS24, Line 3: #include <stdint.h>

missing `<stdbool. […] Done

File src/ericsson-rbs/er_ccu_if.c: https://gerrit.osmocom.org/c/osmo-pcu/+/31176/comment/d8334eac_8012a441 PS24, Line 412: tall_ccu_ctx = ctx;

Either obtain a child ctx here, or simply use `extern void *tall_pcu_ctx;`. Done

-- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31176 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I5c0a76667339ca984a12cbd2052f5d9e5b0f9c4d Gerrit-Change-Number: 31176 Gerrit-PatchSet: 27 Gerrit-Owner: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-CC: fixeria <vyanitskiy@sysmocom.de> Gerrit-CC: neels <nhofmeyr@sysmocom.de> Gerrit-Attention: neels <nhofmeyr@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Comment-Date: Tue, 07 Mar 2023 18:05:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de> Gerrit-MessageType: comment