Attention is currently required from: neels, laforge, fixeria.

View Change

5 comments:

• File configure.ac:

  • Patch Set #24, Line 90: PKG_CHECK_MODULES(LIBOSMOABIS, libosmoabis >= 1.4.0)

    So the E1 CCU feature is configurable via `--enable-er-e1-ccu` and is disabled by default, but you'r […]

    Done

• File contrib/jenkins.sh:

  • Patch Set #24, Line 59: PCU_CONFIG="$PCU_CONFIG --enable-werror --enable-sanitize"

    You should add `--enable-er-e1-ccu` here, so that the conditional code is also built by Jenkins.

    The echo above says explicitly "Direct DSP access disabled, sanitizer enabled" are we sure we want to enable --enable-er-e1-ccu in this path?

• File contrib/osmo-pcu.spec.in:

  • Patch Set #24, Line 36: 1.3.0

    You require 1.4.0 in `configure.ac`, but 1.3. […]

    Done

• File src/ericsson-rbs/er_ccu_descr.h:

  • Patch Set #24, Line 3: #include <stdint.h>

    missing `<stdbool. […]

    Done

• File src/ericsson-rbs/er_ccu_if.c:

  • Patch Set #24, Line 412: tall_ccu_ctx = ctx;

    Either obtain a child ctx here, or simply use `extern void *tall_pcu_ctx;`.

    Done

To view, visit change 31176. To unsubscribe, or for help writing mail filters, visit settings.