Attention is currently required from: pespin.
jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/37817?usp=email )
Change subject: Reject M3UA with "M3UA Network Appearance" ......................................................................
Patch Set 4:
(4 comments)
Commit Message:
https://gerrit.osmocom.org/c/libosmo-sccp/+/37817/comment/e0e2eb77_9255e6cd?... : PS4, Line 13: Related: SYS#6240
OS#6240
Done
File src/m3ua.c:
https://gerrit.osmocom.org/c/libosmo-sccp/+/37817/comment/2fbf88ac_369bb93e?... : PS4, Line 360: static struct xua_msg *m3ua_gen_error_msg(struct osmo_ss7_asp *asp, uint32_t err_code, struct msgb *msg)
May be worth stating that asp can be null here? or it cannot?
Done
https://gerrit.osmocom.org/c/libosmo-sccp/+/37817/comment/2cd94bf7_158b5b46?... : PS4, Line 368: if (!err)
sounds like hidding a bug here without logging?
Done
File src/xua_rkm.c:
https://gerrit.osmocom.org/c/libosmo-sccp/+/37817/comment/5631f8c8_165a9fcb?... : PS4, Line 179: if (xua_msg_find_tag(inner, M3UA_IEI_NET_APPEAR)) {
I'd keep the "/* network appearance (optional) */"
Done
-
jolly