Attention is currently required from: pespin.

View Change

4 comments:

• Commit Message:

  • Patch Set #4, Line 13: Related: SYS#6240

    OS#6240

    Done

• File src/m3ua.c:

  • Patch Set #4, Line 360: static struct xua_msg *m3ua_gen_error_msg(struct osmo_ss7_asp *asp, uint32_t err_code, struct msgb *msg)

    May be worth stating that asp can be null here? or it cannot?

    Done

  • Patch Set #4, Line 368: if (!err)

    sounds like hidding a bug here without logging?

    Done

• File src/xua_rkm.c:

  • Patch Set #4, Line 179: if (xua_msg_find_tag(inner, M3UA_IEI_NET_APPEAR)) {

    I'd keep the "/* network appearance (optional) */"

    Done

To view, visit change 37817. To unsubscribe, or for help writing mail filters, visit settings.