Attention is currently required from: osmith, laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28328 ) Change subject: lchan_select: implement dynamic selection mode for assignment ...................................................................... Patch Set 5: (2 comments) File src/osmo-bsc/abis_rsl.c: https://gerrit.osmocom.org/c/osmo-bsc/+/28328/comment/06c006a8_46d52046 PS5, Line 2010: if (lchan_avail_by_type(rqd->bts, GSM_LCHAN_TCH_F, SELECT_FOR_MS_CHAN_REQ, NULL, true)) {

why pass NULL as ctx, isn't there any other talloc context available to hang this on that makes more […] It's not a talloc context. Actually it's a context of the channel selection/allocation. I am passing NULL in the most cases (chan-req, handover) and a pointer to the current lchan during TCH channel assignment.

File src/osmo-bsc/lchan_select.c: https://gerrit.osmocom.org/c/osmo-bsc/+/28328/comment/258938cc_9c9ea243 PS5, Line 271: } while (0)

why add this instead of using a separate log category where one could enable/disable logging with th […] Conditional logging was here before my patches, I am not adding anything new. I guess it's done on purpose: some functions like _select_sdcch_for_call() from abis_rsl.c or candidate_set_free_tch() from handover_decision_2.c call it with log=false. Most likely, logging is not needed in these cases.

-- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28328 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1b7a0d706976b73cc5c30a8714b830811addfe8d Gerrit-Change-Number: 28328 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: osmith <osmith@sysmocom.de> Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: osmith <osmith@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Thu, 30 Jun 2022 16:35:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith@sysmocom.de> Gerrit-MessageType: comment