Attention is currently required from: osmith, laforge, pespin.

View Change

2 comments:

• File src/osmo-bsc/abis_rsl.c:

  • Patch Set #5, Line 2010: if (lchan_avail_by_type(rqd->bts, GSM_LCHAN_TCH_F, SELECT_FOR_MS_CHAN_REQ, NULL, true)) {

    why pass NULL as ctx, isn't there any other talloc context available to hang this on that makes more […]

    It's not a talloc context. Actually it's a context of the channel selection/allocation. I am passing NULL in the most cases (chan-req, handover) and a pointer to the current lchan during TCH channel assignment.

• File src/osmo-bsc/lchan_select.c:

  • Patch Set #5, Line 271: } while (0)

    why add this instead of using a separate log category where one could enable/disable logging with th […]

    Conditional logging was here before my patches, I am not adding anything new. I guess it's done on purpose: some functions like _select_sdcch_for_call() from abis_rsl.c or candidate_set_free_tch() from handover_decision_2.c call it with log=false. Most likely, logging is not needed in these cases.

To view, visit change 28328. To unsubscribe, or for help writing mail filters, visit settings.