Attention is currently required from: jolly, laforge, osmith, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/35583?usp=email ) Change subject: mobile: implement sending CSD data over UNIX socket ...................................................................... Patch Set 6: (2 comments) File src/host/layer23/src/mobile/tch_data_sock.c: https://gerrit.osmocom.org/c/osmocom-bb/+/35583/comment/e235081d_97ceac1b PS5, Line 168: osmo_fd_read_disable(&state->listen_bfd);

You disable read of socket listening fd. […] Ack, thanks. Fixed in the next patchset revision.

File src/host/layer23/src/mobile/tch_data_sock.c: https://gerrit.osmocom.org/c/osmocom-bb/+/35583/comment/ecfa861f_539b350b PS6, Line 111: osmo_fd_write_disable(bfd);

afaiu this should only be done when llist becomes empty, aka after te "while" Ack. We also leak `msg` here... Fixed in the next patchset revision.

-- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/35583?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Id054af7b3d9d0a41715f7981deb420f6e09bf30c Gerrit-Change-Number: 35583 Gerrit-PatchSet: 6 Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: osmith <osmith@sysmocom.de> Gerrit-CC: jolly <andreas@eversberg.eu> Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: osmith <osmith@sysmocom.de> Gerrit-Attention: jolly <andreas@eversberg.eu> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Sat, 20 Jan 2024 00:26:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: jolly <andreas@eversberg.eu> Comment-In-Reply-To: pespin <pespin@sysmocom.de> Gerrit-MessageType: comment