[M] Change in osmo-remsim[master]: Update osmo-remsim-apitool to support maintenance flag
Attention is currently required from: jolly, lynxis. laforge has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-remsim/+/43747?usp=email ) Change subject: Update osmo-remsim-apitool to support maintenance flag ...................................................................... Patch Set 10: (2 comments) File contrib/osmo-remsim-apitool: https://gerrit.osmocom.org/c/osmo-remsim/+/43747/comment/ed56ea69_d4fbb639?u... : PS10, Line 70: if priority: this matches for 0 and for False (future hopefully None). I would check for '== None' or '== False' as those are different from 0. Same applies to all the 'if priority' clauses in functions above. https://gerrit.osmocom.org/c/osmo-remsim/+/43747/comment/93875220_8230edfa?u... : PS10, Line 84: default of "false" sounds a bit odd for a parameter that has an integer value and no a bool? Shouldn't it be something like None if you want to explicitly diferentiate whether the user has set it (integer) or not (None)? -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/43747?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Iaac6423b3a2f7209d0c26e9624d90b21b7c39f89 Gerrit-Change-Number: 43747 Gerrit-PatchSet: 10 Gerrit-Owner: jolly <andreas@eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: lynxis <lynxis@fe80.eu> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: jolly <andreas@eversberg.eu> Gerrit-Attention: lynxis <lynxis@fe80.eu> Gerrit-Comment-Date: Mon, 16 Nov 2026 16:25:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
participants (1)
-
laforge