Attention is currently required from: jolly, lynxis.
2 comments:
File contrib/osmo-remsim-apitool:
Patch Set #10, Line 70: if priority:
this matches for 0 and for False (future hopefully None). I would check for '== None' or '== False' as those are different from 0. Same applies to all the 'if priority' clauses in functions above.
default of "false" sounds a bit odd for a parameter that has an integer value and no a bool? Shouldn't it be something like None if you want to explicitly diferentiate whether the user has set it (integer) or not (None)?
To view, visit change 43747. To unsubscribe, or for help writing mail filters, visit settings.