Attention is currently required from: dexter. neels has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42274?usp=email ) Change subject: esim/http_json_api: allow URL rewriting ...................................................................... Patch Set 1: Code-Review+1 (4 comments) Patchset: PS1: nothing blocking here, feel free to merge as you see fit! Commit Message: https://gerrit.osmocom.org/c/pysim/+/42274/comment/07c133c0_b73f763b?usp=ema... : PS1, Line 15: reqrite_url (typo) File pySim/esim/http_json_api.py: https://gerrit.osmocom.org/c/pysim/+/42274/comment/f26df76c_487ad55d?usp=ema... : PS1, Line 373: reqriting (typo) https://gerrit.osmocom.org/c/pysim/+/42274/comment/d46ac3f2_5f524633?usp=ema... : PS1, Line 391: data maybe it would be good to complete composition of data before calling rewrite_url()? i mean, maybe rather call rewrite_url() below this line, not above? the header shouldn't ever be relevant for rewrite_url, i'm just thinking it would be logically simpler when there is only one relevant state for data... (unless you chose this order on purpose) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42274?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Id2713a867079cc140517fe312189e5e2162608a5 Gerrit-Change-Number: 42274 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> Gerrit-Attention: dexter <pmaier@sysmocom.de> Gerrit-Comment-Date: Fri, 06 Mar 2026 20:11:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes