Attention is currently required from: dexter.
Patch set 1:Code-Review +1
4 comments:
Patchset:
nothing blocking here, feel free to merge as you see fit!
Commit Message:
Patch Set #1, Line 15: reqrite_url
(typo)
File pySim/esim/http_json_api.py:
Patch Set #1, Line 373: reqriting
(typo)
maybe it would be good to complete composition of data before calling rewrite_url()? i mean, maybe rather call rewrite_url() below this line, not above?
the header shouldn't ever be relevant for rewrite_url, i'm just thinking it would be logically simpler when there is only one relevant state for data...
(unless you chose this order on purpose)
To view, visit change 42274. To unsubscribe, or for help writing mail filters, visit settings.