Attention is currently required from: Hoernchen.
dexter has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/pysim/+/43561?usp=email )
Change subject: cat: properly decode IMEI/IMEISV IE ......................................................................
Patch Set 2: Code-Review+2
(3 comments)
Patchset:
PS2: I have looked through the encoding and decoding implementation, to me this appears to be correct.
Commit Message:
https://gerrit.osmocom.org/c/pysim/+/43561/comment/2ac9add0_77b01094?usp=ema... : PS2, Line 9: Currently BcdAdapter(GreedyBytes), a plain missing word: ..., is a plain sapped..." ?
File pySim/cat.py:
https://gerrit.osmocom.org/c/pysim/+/43561/comment/311660b2_b638c53b?usp=ema... : PS2, Line 350: digits = digits[:-1] # drop the 1111 end mark This is so weird becaus the first digit is in the higher nibble of octet 3 - maybe worth a comment. I don't know...
-
dexter