Attention is currently required from: Hoernchen.

Patch set 2:Code-Review +2

View Change

3 comments:

• Patchset:

  • Patch Set #2:

    I have looked through the encoding and decoding implementation, to me this appears to be correct.

• Commit Message:

  • Patch Set #2, Line 9: Currently BcdAdapter(GreedyBytes), a plain

    missing word: ..., is a plain sapped..." ?

• File pySim/cat.py:

  • Patch Set #2, Line 350: digits = digits[:-1] # drop the 1111 end mark

    This is so weird becaus the first digit is in the higher nibble of octet 3 - maybe worth a comment. I don't know...

To view, visit change 43561. To unsubscribe, or for help writing mail filters, visit settings.