Attention is currently required from: pespin, dexter. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32932 ) Change subject: ASCI: Add message definition and encoding according to 3GPP TS 48.008 ...................................................................... Patch Set 13: (4 comments) File include/osmocom/gsm/gsm0808.h: https://gerrit.osmocom.org/c/libosmocore/+/32932/comment/981d1c5c_eba57466 PS12, Line 22: #ifdef HAVE_SYS_SOCKET_H

Something to look into would be having a socket_compat.h (similar to timer_compat. […] Done

File include/osmocom/gsm/protocol/gsm_08_08.h: https://gerrit.osmocom.org/c/libosmocore/+/32932/comment/cccaa315_3945599a PS12, Line 175: BSS_MAP_MSG_UPLINK_REJECT_CMD = 75,

(not critical: you only change the formatting here. […] Done

File src/gsm/gsm0808.c: https://gerrit.osmocom.org/c/libosmocore/+/32932/comment/4af260ba_233b9060 PS12, Line 22: #ifdef HAVE_SYS_SOCKET_H

As far as I understand from the discussion around patch-set 5, this is to prevent building this code […] This is not required anymore, I removed it.

File tests/tlv/tlv_test.c: https://gerrit.osmocom.org/c/libosmocore/+/32932/comment/ad7e56b1_fc5a54e8 PS12, Line 4:

TLV parsing should work on embedded targets. […] This is not required anymore, I removed it.

-- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32932 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib94c64136c31ce4af67c314a8550d93946cc844f Gerrit-Change-Number: 32932 Gerrit-PatchSet: 13 Gerrit-Owner: jolly <andreas@eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-CC: dexter <pmaier@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Attention: dexter <pmaier@sysmocom.de> Gerrit-Comment-Date: Fri, 09 Jun 2023 10:41:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin@sysmocom.de> Comment-In-Reply-To: dexter <pmaier@sysmocom.de> Gerrit-MessageType: comment