Attention is currently required from: pespin, dexter.

View Change

4 comments:

• File include/osmocom/gsm/gsm0808.h:

  • Patch Set #12, Line 22: #ifdef HAVE_SYS_SOCKET_H

    Something to look into would be having a socket_compat.h (similar to timer_compat. […]

    Done

• File include/osmocom/gsm/protocol/gsm_08_08.h:

  • Patch Set #12, Line 175: BSS_MAP_MSG_UPLINK_REJECT_CMD = 75,

    (not critical: you only change the formatting here. […]

    Done

• File src/gsm/gsm0808.c:

  • Patch Set #12, Line 22: #ifdef HAVE_SYS_SOCKET_H

    As far as I understand from the discussion around patch-set 5, this is to prevent building this code […]

    This is not required anymore, I removed it.

• File tests/tlv/tlv_test.c:

  • Patch Set #12, Line 4:

    TLV parsing should work on embedded targets. […]

    This is not required anymore, I removed it.

To view, visit change 32932. To unsubscribe, or for help writing mail filters, visit settings.