Attention is currently required from: fixeria, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43873?usp=email ) Change subject: smf: Introduce test TC_pfcp_heartbeat_timeout ...................................................................... Patch Set 6: Code-Review+1 (2 comments) File smf/SMF_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43873/comment/d8203047_8202b... : PS6, Line 616: * on other tests executed afterwards and maing them fail due to unexpected msg received: ```suggestion * on other tests executed afterwards and making them fail due to unexpected msg received: ``` https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43873/comment/36d2008e_a66d6... : PS6, Line 621: setverdict(fail, "https://github.com/open5gs/open5gs/issues/4860"); I wonder if this could be solved more elegantly, something like this (pseudocode): ``` f_prometheus_expect(valueof(t_Metrics_Expect(1, 0)), wait_converge := true); if (verdict is failed) { f_s5s8_delete_session(omit, Request_accepted); } ``` But probably not worth investing much time into this. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43873?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I27daa6636e45909d6d83a46af094108e71efc552 Gerrit-Change-Number: 43873 Gerrit-PatchSet: 6 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: osmith <osmith@sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Tue, 13 Oct 2026 13:48:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes