Attention is currently required from: fixeria, pespin.

Patch set 6:Code-Review +1

View Change

2 comments:

• File smf/SMF_Tests.ttcn:

  • Patch Set #6, Line 616: * on other tests executed afterwards and maing them fail due to unexpected msg received:

    ```suggestion
    	 * on other tests executed afterwards and making them fail due to unexpected msg received:
    ```

  • Patch Set #6, Line 621: setverdict(fail, "https://github.com/open5gs/open5gs/issues/4860");

    I wonder if this could be solved more elegantly, something like this (pseudocode):

    ```
    f_prometheus_expect(valueof(t_Metrics_Expect(1, 0)), wait_converge := true);

    if (verdict is failed) {
      f_s5s8_delete_session(omit, Request_accepted);
    }
    ```

    But probably not worth investing much time into this.

To view, visit change 43873. To unsubscribe, or for help writing mail filters, visit settings.