Attention is currently required from: lynxis lazus. Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/39560?usp=email ) Change subject: add libvlr based on MSC commit 80955b9454776166dd43972db2141b431444ad7f ...................................................................... Patch Set 6: (30 comments) File include/osmocom/vlr/vlr.h: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/b72528dc_f07cc70c?usp... : PS6, Line 122: long long unsigned int id; type 'long long unsigned int' should be specified in [[un]signed] [short|int|long|long long] order File src/libvlr/vlr.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/abe3c36b_f1be47d4?usp... : PS6, Line 240: OSMO_STRBUF_PRINTF(sb, "%sMSISDN-%s", present? ":" : "", vsub->msisdn); spaces required around that '?' (ctx:VxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/db4494fd_b5e9e4b7?usp... : PS6, Line 244: OSMO_STRBUF_PRINTF(sb, "%sTMSI-0x%08X", present? ":" : "", vsub->tmsi); spaces required around that '?' (ctx:VxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/afda9220_9ef80da6?usp... : PS6, Line 248: OSMO_STRBUF_PRINTF(sb, "%sTMSInew-0x%08X", present? ":" : "", vsub->tmsi_new); spaces required around that '?' (ctx:VxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/c42709ea_1f2acee5?usp... : PS6, Line 260: char *name = (char*)vlr_subscr_name(vsub); "(foo\*)" should be "(foo \*)" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/c271f61d_476238ca?usp... : PS6, Line 265: strcpy(name + maxlen - 2, ".."); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/e87a2c53_975617ab?usp... : PS6, Line 382: vlr_subscr_name(vsub), (e->count - old_use_count) > 0? "+" : "-", e->use, spaces required around that '?' (ctx:VxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/ae3871b9_8a9e1020?usp... : PS6, Line 715: osmo_plmn_name(&vsub->sgs.last_eutran_plmn) : code indent should use tabs where possible Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/ab57aad8_6ef3766c?usp... : PS6, Line 820: struct sgsn_subscriber_pdp_data* pdata; "foo\* bar" should be "foo \*bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/9fbab4c3_584a0bc8?usp... : PS6, Line 1453: VLR_AUTH_E_MS_ID_IMSI, (void*)mi->imsi); "(foo\*)" should be "(foo \*)" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/602ba169_84b327df?usp... : PS6, Line 1461: return osmo_fsm_inst_dispatch(vsub->lu_fsm, VLR_ULA_E_ID_IMSI, (void*)mi->imsi); "(foo\*)" should be "(foo \*)" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/695682be_643fba00?usp... : PS6, Line 1463: return osmo_fsm_inst_dispatch(vsub->lu_fsm, VLR_ULA_E_ID_IMEI, (void*)mi->imei); "(foo\*)" should be "(foo \*)" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/b82fc2fa_3ec4265d?usp... : PS6, Line 1465: return osmo_fsm_inst_dispatch(vsub->lu_fsm, VLR_ULA_E_ID_IMEISV, (void*)mi->imeisv); "(foo\*)" should be "(foo \*)" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/c07d4685_c2b72cf2?usp... : PS6, Line 1736: struct vlr_subscr **fsub = (void*)&target->filter_data[LOG_FLT_VLR_SUBSCR]; "(foo\*)" should be "(foo \*)" File src/libvlr/vlr_access_req_fsm.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/32e0f2bf_2136ad61?usp... : PS6, Line 111: return par->result? gsm48_reject_value_name(par->result) : "PASSED"; spaces required around that '?' (ctx:VxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/9b618965_168b639a?usp... : PS6, Line 415: } else { else is not generally useful after a break or return Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/3bc042d8_f57333f2?usp... : PS6, Line 421: } else { else is not generally useful after a break or return Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/b8f66492_919435e1?usp... : PS6, Line 496: result = *(enum vlr_ciph_result_cause*)data; "(foo\*)" should be "(foo \*)" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/387b0d03_582b3454?usp... : PS6, Line 791: .in_event_mask = , space prohibited before that ',' (ctx:WxE) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/160469d6_15f67607?usp... : PS6, Line 798: .in_event_mask = , space prohibited before that ',' (ctx:WxE) File src/libvlr/vlr_auth_fsm.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/48515112_7214cb4e?usp... : PS6, Line 199: res_len, (res_len == vec->res_len)? "valid" : "INVALID on UTRAN"); spaces required around that '?' (ctx:VxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/5cfcce50_20f07252?usp... : PS6, Line 216: } else { else is not generally useful after a break or return File src/libvlr/vlr_lu_fsm.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/cf50a34d_bb46df99?usp... : PS6, Line 160: return (struct vlr_subscr*)fi->priv; "(foo\*)" should be "(foo \*)" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/22cc066c_2068b4c9?usp... : PS6, Line 272: return (struct vlr_subscr*)fi->priv; "(foo\*)" should be "(foo \*)" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/dc2168c6_f3c843fa?usp... : PS6, Line 671: return (struct lu_compl_vlr_priv*)fi->priv; "(foo\*)" should be "(foo \*)" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/375f1805_122d3de3?usp... : PS6, Line 1274: result = *(enum vlr_ciph_result_cause*)data; "(foo\*)" should be "(foo \*)" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/2e477c45_26cc3fa3?usp... : PS6, Line 1396: cause = *(uint8_t*)data; "(foo\*)" should be "(foo \*)" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/9f359382_ad2ddedb?usp... : PS6, Line 1428: cause = *(uint8_t*)data; "(foo\*)" should be "(foo \*)" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/67766e6e_d8238161?usp... : PS6, Line 1638: return (struct lu_fsm_priv*)fi->priv; "(foo\*)" should be "(foo \*)" File src/libvlr/vlr_sgs.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/b87017de_476524ed?usp... : PS6, Line 324: } void function return statements are not generally useful -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39560?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I221114e00e6f338a75ae0dd7ac285e262b23635d Gerrit-Change-Number: 39560 Gerrit-PatchSet: 6 Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis@fe80.eu> Gerrit-Comment-Date: Mon, 31 Aug 2026 15:56:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No