Attention is currently required from: lynxis lazus.

View Change

30 comments:

• File include/osmocom/vlr/vlr.h:

  • Robot Comment from checkpatch (run ID ):

    Patch Set #6, Line 122: long long unsigned int id;

    type 'long long unsigned int' should be specified in [[un]signed] [short|int|long|long long] order

• File src/libvlr/vlr.c:

  • Robot Comment from checkpatch (run ID ):

    Patch Set #6, Line 240: OSMO_STRBUF_PRINTF(sb, "%sMSISDN-%s", present? ":" : "", vsub->msisdn);

    spaces required around that '?' (ctx:VxW)

  • Robot Comment from checkpatch (run ID ):

    Patch Set #6, Line 244: OSMO_STRBUF_PRINTF(sb, "%sTMSI-0x%08X", present? ":" : "", vsub->tmsi);

    spaces required around that '?' (ctx:VxW)

  • Robot Comment from checkpatch (run ID ):

    Patch Set #6, Line 248: OSMO_STRBUF_PRINTF(sb, "%sTMSInew-0x%08X", present? ":" : "", vsub->tmsi_new);

    spaces required around that '?' (ctx:VxW)

  • Robot Comment from checkpatch (run ID ):

    Patch Set #6, Line 260: char *name = (char*)vlr_subscr_name(vsub);

    "(foo\*)" should be "(foo \*)"

  • Robot Comment from checkpatch (run ID ):

    Patch Set #6, Line 265: strcpy(name + maxlen - 2, "..");

    Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY()

  • Robot Comment from checkpatch (run ID ):

    Patch Set #6, Line 382: vlr_subscr_name(vsub), (e->count - old_use_count) > 0? "+" : "-", e->use,

    spaces required around that '?' (ctx:VxW)

  • Robot Comment from checkpatch (run ID ):

    Patch Set #6, Line 715: osmo_plmn_name(&vsub->sgs.last_eutran_plmn) :

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID ):

    Patch Set #6, Line 820: struct sgsn_subscriber_pdp_data* pdata;

    "foo\* bar" should be "foo \*bar"

  • Robot Comment from checkpatch (run ID ):

    Patch Set #6, Line 1453: VLR_AUTH_E_MS_ID_IMSI, (void*)mi->imsi);

    "(foo\*)" should be "(foo \*)"

  • Robot Comment from checkpatch (run ID ):

    Patch Set #6, Line 1461: return osmo_fsm_inst_dispatch(vsub->lu_fsm, VLR_ULA_E_ID_IMSI, (void*)mi->imsi);

    "(foo\*)" should be "(foo \*)"

  • Robot Comment from checkpatch (run ID ):

    Patch Set #6, Line 1463: return osmo_fsm_inst_dispatch(vsub->lu_fsm, VLR_ULA_E_ID_IMEI, (void*)mi->imei);

    "(foo\*)" should be "(foo \*)"

  • Robot Comment from checkpatch (run ID ):

    Patch Set #6, Line 1465: return osmo_fsm_inst_dispatch(vsub->lu_fsm, VLR_ULA_E_ID_IMEISV, (void*)mi->imeisv);

    "(foo\*)" should be "(foo \*)"

  • Robot Comment from checkpatch (run ID ):

    Patch Set #6, Line 1736: struct vlr_subscr **fsub = (void*)&target->filter_data[LOG_FLT_VLR_SUBSCR];

    "(foo\*)" should be "(foo \*)"

• File src/libvlr/vlr_access_req_fsm.c:

  • Robot Comment from checkpatch (run ID ):

    Patch Set #6, Line 111: return par->result? gsm48_reject_value_name(par->result) : "PASSED";

    spaces required around that '?' (ctx:VxW)

  • Robot Comment from checkpatch (run ID ):

    Patch Set #6, Line 415: } else {

    else is not generally useful after a break or return

  • Robot Comment from checkpatch (run ID ):

    Patch Set #6, Line 421: } else {

    else is not generally useful after a break or return

  • Robot Comment from checkpatch (run ID ):

    Patch Set #6, Line 496: result = *(enum vlr_ciph_result_cause*)data;

    "(foo\*)" should be "(foo \*)"

  • Robot Comment from checkpatch (run ID ):

    Patch Set #6, Line 791: .in_event_mask = ,

    space prohibited before that ',' (ctx:WxE)

  • Robot Comment from checkpatch (run ID ):

    Patch Set #6, Line 798: .in_event_mask = ,

    space prohibited before that ',' (ctx:WxE)

• File src/libvlr/vlr_auth_fsm.c:

  • Robot Comment from checkpatch (run ID ):

    Patch Set #6, Line 199: res_len, (res_len == vec->res_len)? "valid" : "INVALID on UTRAN");

    spaces required around that '?' (ctx:VxW)

  • Robot Comment from checkpatch (run ID ):

    Patch Set #6, Line 216: } else {

    else is not generally useful after a break or return

• File src/libvlr/vlr_lu_fsm.c:

  • Robot Comment from checkpatch (run ID ):

    Patch Set #6, Line 160: return (struct vlr_subscr*)fi->priv;

    "(foo\*)" should be "(foo \*)"

  • Robot Comment from checkpatch (run ID ):

    Patch Set #6, Line 272: return (struct vlr_subscr*)fi->priv;

    "(foo\*)" should be "(foo \*)"

  • Robot Comment from checkpatch (run ID ):

    Patch Set #6, Line 671: return (struct lu_compl_vlr_priv*)fi->priv;

    "(foo\*)" should be "(foo \*)"

  • Robot Comment from checkpatch (run ID ):

    Patch Set #6, Line 1274: result = *(enum vlr_ciph_result_cause*)data;

    "(foo\*)" should be "(foo \*)"

  • Robot Comment from checkpatch (run ID ):

    Patch Set #6, Line 1396: cause = *(uint8_t*)data;

    "(foo\*)" should be "(foo \*)"

  • Robot Comment from checkpatch (run ID ):

    Patch Set #6, Line 1428: cause = *(uint8_t*)data;

    "(foo\*)" should be "(foo \*)"

  • Robot Comment from checkpatch (run ID ):

    Patch Set #6, Line 1638: return (struct lu_fsm_priv*)fi->priv;

    "(foo\*)" should be "(foo \*)"

• File src/libvlr/vlr_sgs.c:

  • Robot Comment from checkpatch (run ID ):

    Patch Set #6, Line 324: }

    void function return statements are not generally useful

To view, visit change 39560. To unsubscribe, or for help writing mail filters, visit settings.