Attention is currently required from: lynxis lazus, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35625?usp=email ) Change subject: gsm_04_08_gprs.h: Introduce packed struct gsm48_pdp_address ...................................................................... Patch Set 1: (3 comments) File include/osmocom/gsm/protocol/gsm_04_08_gprs.h: https://gerrit.osmocom.org/c/libosmocore/+/35625/comment/1cf9eba3_e3eaab82 PS1, Line 316: uint8_t organization:4, /* enum gsm48_pdp_type_org */ alignment issues https://gerrit.osmocom.org/c/libosmocore/+/35625/comment/98fc46f0_83cc1f32 PS1, Line 337: uint32_t v4; likewise, alignment issues https://gerrit.osmocom.org/c/libosmocore/+/35625/comment/db018948_54337a8b PS1, Line 340: ietf So the total size of this union is 20 (determined by size of `v4v6`). It's not a problem when parsing a Packet Data Protocol Address IE, but may be a problem when encoding it with either `PDP_TYPE_N_IETF_IPv4` or `PDP_TYPE_N_IETF_IPv6`, because doing `msgb_put(msg, sizeof(struct gsm48_pdp_address))` is only valid for `PDP_TYPE_N_IETF_IPv4v6`. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35625?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I453ced42dd36df3a6ddb5db67093df5a22cad18c Gerrit-Change-Number: 35625 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis@fe80.eu> Gerrit-Comment-Date: Fri, 19 Jan 2024 22:09:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment