[XL] Change in pysim[master]: cattp: ETSI TS 102 127 transport for OTA over BIP UDP
Attention is currently required from: Hoernchen. dexter has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/pysim/+/43719?usp=email ) Change subject: cattp: ETSI TS 102 127 transport for OTA over BIP UDP ...................................................................... Patch Set 2: Code-Review+1 (2 comments) File pySim/cattp.py: https://gerrit.osmocom.org/c/pysim/+/43719/comment/64dee19c_3cfc4e28?usp=ema... : PS2, Line 99: NoVar = Struct(Terminated) maybe re-order those a bit. SynVar,RstVar,EackVar,NoVar is the order in var_struct https://gerrit.osmocom.org/c/pysim/+/43719/comment/15982e8f_255fa46b?usp=ema... : PS2, Line 102: 'nul': FLAG_NUL, 'seg': FLAG_SEG} maybe put those next to the constants? Or above the definition of PduStruct? You are using the constants but not FLAG_BITS directly here, so now this dict is between the var_struct and the struct definitions above. This is a bit confusing. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/43719?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6f31493c1f0fb48fb3fd5382d8af2c905d365e54 Gerrit-Change-Number: 43719 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Attention: Hoernchen <ewild@sysmocom.de> Gerrit-Comment-Date: Thu, 19 Nov 2026 13:17:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
participants (1)
-
dexter