Attention is currently required from: Hoernchen.
Patch set 2:Code-Review +1
2 comments:
File pySim/cattp.py:
Patch Set #2, Line 99: NoVar = Struct(Terminated)
maybe re-order those a bit. SynVar,RstVar,EackVar,NoVar is the order in var_struct
Patch Set #2, Line 102: 'nul': FLAG_NUL, 'seg': FLAG_SEG}
maybe put those next to the constants? Or above the definition of PduStruct? You are using the constants but not FLAG_BITS directly here, so now this dict is between the var_struct and the struct definitions above. This is a bit confusing.
To view, visit change 43719. To unsubscribe, or for help writing mail filters, visit settings.