Attention is currently required from: dexter, laforge.

lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/simtrace2/+/43185?usp=email )

Change subject: Add osmo_apdu_segment_in2() to ensure correct parsing of GP GET DATA ......................................................................

Patch Set 8:

(2 comments)

File host/lib/apdu_dispatch.c:

https://gerrit.osmocom.org/c/simtrace2/+/43185/comment/4bf80757_c47bf41a?usp... : PS3, Line 120: ac->hdr.cla & 0x80 && /* check for GP */

In GlobalPlatform Card Specification, section 11.3.2 they list more possible CLA bytes. […]

I don't know what I should do here. Should I drop the requirement for Global Platform and treat all previous case 2 as a case 2?Or keep the code as it?

File host/tests/apdu_dispatch/apdu_dispatch_test.c:

https://gerrit.osmocom.org/c/simtrace2/+/43185/comment/83cfd253_ebb0fbcf?usp... : PS3, Line 70: OSMO_ASSERT(rc == APDU_ACT_TX_CAPDU_TO_CARD);

I wonder if it would make sense to inspect the contents of ac and prev_ac after osmo_apdu_segment_in […]

I've added a check on apdu_case.