Attention is currently required from: dexter, laforge.

View Change

2 comments:

• File host/lib/apdu_dispatch.c:

  • Patch Set #3, Line 120: ac->hdr.cla & 0x80 && /* check for GP */

    In GlobalPlatform Card Specification, section 11.3.2 they list more possible CLA bytes. […]

    I don't know what I should do here. Should I drop the requirement for Global Platform and treat all previous case 2 as a case 2?Or keep the code as it?

• File host/tests/apdu_dispatch/apdu_dispatch_test.c:

  • Patch Set #3, Line 70: OSMO_ASSERT(rc == APDU_ACT_TX_CAPDU_TO_CARD);

    I wonder if it would make sense to inspect the contents of ac and prev_ac after osmo_apdu_segment_in […]

    I've added a check on apdu_case.

To view, visit change 43185. To unsubscribe, or for help writing mail filters, visit settings.