Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28822 ) Change subject: sbcap: Request and handle Write Replace Warning Indication ...................................................................... Patch Set 3: (4 comments) File include/osmocom/cbc/sbcap_msg.h: https://gerrit.osmocom.org/c/osmo-cbc/+/28822/comment/e44944ee_a5faf74b PS3, Line 15: (extra blank line) File include/osmocom/cbc/smscb_message_fsm.h: https://gerrit.osmocom.org/c/osmo-cbc/+/28822/comment/8df179f7_3a1fa8e8 PS3, Line 35: SMSCB_E_SBCAP_WRITE_IND, are you sure the name shouldn't reflect more than "WRITE" if it is called Write Replace Warning? File src/sbcap_msg.c: https://gerrit.osmocom.org/c/osmo-cbc/+/28822/comment/1a4014be_c714f710 PS3, Line 231: ie = sbcap_alloc_Write_Replace_Warning_Request_IE(24, SBcAP_Criticality_ignore, is 24 a magic nr or a placeholder token? i guess it's the way how this file does things, but i as unfamiliar reader don't understand the numbers... File src/smscb_peer_fsm.c: https://gerrit.osmocom.org/c/osmo-cbc/+/28822/comment/9624f320_1f13abd7 PS3, Line 302: struct cbc_cell_id *cci = NULL; // FIXME: lookup merge this FIXME? if so explain in the commit log? -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28822 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I563e7d1c999f14b8197bb41e85b7bcf6262fe2a0 Gerrit-Change-Number: 28822 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-CC: neels <nhofmeyr@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Thu, 28 Jul 2022 21:03:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment