Attention is currently required from: pespin.

View Change

4 comments:

• File include/osmocom/cbc/sbcap_msg.h:

  • Patch Set #3, Line 15:

    (extra blank line)

• File include/osmocom/cbc/smscb_message_fsm.h:

  • Patch Set #3, Line 35: SMSCB_E_SBCAP_WRITE_IND,

    are you sure the name shouldn't reflect more than "WRITE" if it is called Write Replace Warning?

• File src/sbcap_msg.c:

  • Patch Set #3, Line 231: ie = sbcap_alloc_Write_Replace_Warning_Request_IE(24, SBcAP_Criticality_ignore,

    is 24 a magic nr or a placeholder token?
    i guess it's the way how this file does things, but i as unfamiliar reader don't understand the numbers...

• File src/smscb_peer_fsm.c:

  • Patch Set #3, Line 302: struct cbc_cell_id *cci = NULL; // FIXME: lookup

    merge this FIXME?
    if so explain in the commit log?

To view, visit change 28822. To unsubscribe, or for help writing mail filters, visit settings.