Attention is currently required from: neels, laforge, pespin, dexter.
neels has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/29475 )
Change subject: fix gsm0808_sc_cfg <-> gsm48_mr_cfg conversion
......................................................................
Patch Set 3:
(4 comments)
Commit Message:
https://gerrit.osmocom.org/c/libosmocore/+/29475/comment/0567b865_547d3b2e
PS2, Line 17: gsm0808_sc_cfg_from_modes() and
added "_amr"
Done
File src/gsm/gsm0808_utils.c:
https://gerrit.osmocom.org/c/libosmocore/+/29475/comment/55be7e5f_b3466146
PS1, Line 1659: uint8_t gsm0808_sc_cfg_get_best_modes(uint16_t s15_s0, bool full_rate)
makes sense, yes
actually "best"
refers to the "best Sn combination", not the highest rate. For example, S1 is
considered better than S0 and S2 thru S9, because it has a range of different rates, etc
File src/gsm/gsm0808_utils.c:
https://gerrit.osmocom.org/c/libosmocore/+/29475/comment/111a8389_a7323a59
PS2, Line 1612: if (s_modes && ((s_modes & modes) == s_modes))
it is possible, for example some modes are disabled
for HR, […]
Done
https://gerrit.osmocom.org/c/libosmocore/+/29475/comment/56bea5ef_1d06689d
PS2, Line 1635: if (!(s15_s0 & s_bit))
thanks, nice catch.
Done
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/29475
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I900fda192742fa8f6dd54e9131ef1704b14cc41a
Gerrit-Change-Number: 29475
Gerrit-PatchSet: 3
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 28 Feb 2023 00:24:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment